Accept Tap 16 #188
Open
Accept Tap 16 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Merkle tree requirements did not allow for optimizations like those used in the rust implementation. This pr describes the properties needed, while leaving details to a POUF. It also adds a link to the rust implementation. Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
trishankatdatadog
previously approved these changes
Apr 11, 2024
Signed-off-by: Marina Moore <[email protected]>
trishankatdatadog
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the rust implementation, makes a couple of simplifications to the specification section to ensure the efficient Merkle BPT implementation is supported, and moves the TAP to accepted.